Skip to content

Sigurd/web 53 event pages edit or delete buttons #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0xSpecter wants to merge 56 commits into
base: master
Choose a base branch
from
Open

Sigurd/web 53 event pages edit or delete buttons #1976

0xSpecter wants to merge 56 commits into from

Conversation

@0xSpecter
Copy link
Contributor

@0xSpecter 0xSpecter commented Oct 2, 2025

No description provided.

eilifhl and others added 21 commits September 23, 2025 20:59
@eilifhl
Add darkmode to storybook
575a499
@eilifhl
Remove bg color
fa443e5
@eilifhl
Revise Venue Opening Dto
f14c2a2
@eilifhl
Change route naming
a1d65d0
@eilifhl
Change request from patch to get
9d3231f
@eilifhl
Create open_venues function in VenueView
cb63071
@eilifhl
Generate routes
532c81b
@eilifhl
Remove irrelevant routes changes
1bd43d8
@eilifhl
Merge branch 'master' into Eilif/1942-get-opening-hours-for-homepage-…
9d3188e 
…backend
@eilifhl
Refactor api call to deliver venue list instead of new datatype
9781938
@eilifhl
Merge branch 'master' into Eilif/1942-get-opening-hours-for-homepage-…
697e60e 
…backend
@eilifhl
Create container component
567abe2
@eilifhl
Merge branch 'Eilif/1942-get-opening-hours-for-homepage-backend' of g…
c8e02d5 
…ithub.com:Samfundet/Samfundet4 into Eilif/1942-get-opening-hours-for-homepage-backend
@eilifhl
Refactor so all logic is in OpeningHours.tsx
e01573d
@eilifhl
Remove OpeningHoursContainer from HomePage
fcb4de4
@eilifhl
BIOMEEEEEE
dc90eb2
@eilifhl
STYLELIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIINTTTTTT
2880626
@eilifhl
Add correct storybook data
4df319a
@0xSpecter
added edit button inside of event page
4779db9
@0xSpecter
added edit button to image card in events page
5dde5b1
@0xSpecter
fixes
b058f47
@0xSpecter
Copy link
Contributor Author

0xSpecter commented Oct 2, 2025

plz merge 🥺🥺🥺

@andsamfu
Copy link
Contributor

andsamfu commented Oct 7, 2025

Lagt til kommentarer til videre forbedringer i linear
https://linear.app/mgweb/issue/WEB-53/event-pages-edit-or-delete-buttons

@0xSpecter
added a checkbox for making samf closed, needs to be implemented in m…
4509f48 
…ore places then just openinghours as it uses the globalcontext
andsamfu
andsamfu requested changes Oct 30, 2025
View reviewed changes
hei98
hei98 reviewed Jan 20, 2026
View reviewed changes
@0xSpecter 0xSpecter requested a review from andsamfu January 22, 2026 13:54
andsamfu
andsamfu requested changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@andsamfu andsamfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser du har merged en annen branch/PR inn i den her fra commit 714977f som er PR 1991

Kan du skille dette fra hverandre igjen slik at det blir mer ryddig å gjøre review?

@0xSpecter 0xSpecter requested a review from andsamfu January 22, 2026 20:28
@hei98
Copy link
Contributor

hei98 commented Jan 25, 2026

Ser du har merged en annen branch/PR inn i den her fra commit 714977f som er PR 1991

Kan du skille dette fra hverandre igjen slik at det blir mer ryddig å gjøre review?

Enig i dette. Er vanskelig å se hva som er for denne pr-en med alle de andre filene for de andre pr-ene.

I tillegg lurer jeg på om vi skulle ha lagt til edit og delete på table/bord oversikten for events også? For nå er det kun lagt til for card/kort oversikten for events, så hvis noen bruker table oversikten tenker jeg det er greit å ha det der og.

image

@0xSpecter
Copy link
Contributor Author

0xSpecter commented Feb 10, 2026

Her må du ignorere koden som kommer fra tidligere prs fra meg og eilif (som jeg merga sammen :DD). det faktisk er endret her er: Alt i components, eventpage, eventlist og eventcarousel

aTrueYety
aTrueYety reviewed Feb 10, 2026
View reviewed changes
frontend/src/Components/EventEditButtons/EventEditButtons.stories.tsx
},
};

export default meta;
Copy link
Contributor

@aTrueYety aTrueYety Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant see this one in storybook

@aTrueYety
Copy link
Contributor

aTrueYety commented Feb 11, 2026

Are the changes form the other PRs neccesary for this one? If not could you rebase and skip those changes? If they are then you can mark this PR as blocked untill they are in master and rebase once ready. This seemes unnecessarily complicated to review.

@aTrueYety aTrueYety mentioned this pull request Feb 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aTrueYety aTrueYety aTrueYety left review comments

@hei98 hei98 hei98 left review comments

@robines robines Awaiting requested review from robines robines is a code owner

@Snorre98 Snorre98 Awaiting requested review from Snorre98

@andsamfu andsamfu Awaiting requested review from andsamfu andsamfu is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@0xSpecter 0xSpecter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@0xSpecter @andsamfu @hei98 @aTrueYety @eilifhl